fix: skip cleanup if build is skipped #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The env var
XCADDY_SKIP_BUILD
is supposed to implyXCADDY_SKIP_CLEANUP
, but the implementation missed this detail. TheBuilder#Build
method hasdefer buildEnv.Close()
, which runs even on the early exit here:xcaddy/builder.go
Lines 80 to 86 in c795956
The
environment#Close
method does not know about(Builder).SkipBuild
. We can overload theskipCleanup
semantics because skipping build implies skipping cleanup.