Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registry already registered check #1054

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Feb 8, 2021

What changed?
Also check chained registry when checking if an activity/workflow function is already registered.

Why?
Also check chained registry when checking if an activity/workflow function is already registered.

How did you test it?
Unit test.

Potential risks
in the worst case, the already registered check maybe broken, causing register function to fail or panic.

@yycptt yycptt requested a review from meiliang86 February 8, 2021 18:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5a9ee3f6-bbb0-42d7-8b38-3feedd410706

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 74.819%

Files with Coverage Reduction New Missed Lines %
internal/internal_task_pollers.go 2 75.25%
Totals Coverage Status
Change from base Build 438753a1-0d24-4662-8662-b8c1982f371f: 0.03%
Covered Lines: 9612
Relevant Lines: 12847

💛 - Coveralls

@meiliang86 meiliang86 merged commit e462133 into cadence-workflow:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants