Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce 85% new line coverage #1325

Conversation

taylanisikdemir
Copy link
Member

What changed?
Updating codecov's patch setting to enforce new line coverage is above 85%.
Similar to what we have on Cadence repo: cadence-workflow/cadence#5805

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Merging #1325 (6dd59dc) into master (81a37e4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81a37e4...6dd59dc. Read the comment docs.

Copy link
Contributor

@Groxx Groxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm 👍

how do we work around this if it's too much red tape? there's always the admin-merge of course, but is there another option?

@taylanisikdemir
Copy link
Member Author

sgtm 👍

how do we work around this if it's too much red tape? there's always the admin-merge of course, but is there another option?

I didn't see a bypass option via tag etc. exposed by codecov. Current options are:

  • Admin merge
  • Change the threshold in codecov.yml in the PR and then revert it back as follow up

@taylanisikdemir taylanisikdemir merged commit d17db37 into cadence-workflow:master Mar 25, 2024
13 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/enforce_patch_cov branch March 25, 2024 21:27
@Groxx
Copy link
Contributor

Groxx commented Mar 25, 2024

reasonably discoverable workarounds anyway. makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants