Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option to exclude the list of workflows by Type #1335

Merged
merged 1 commit into from
May 3, 2024

Conversation

agautam478
Copy link
Contributor

What changed?

  • Added a new option to exculde the Workflows by Type from replay by Shadower.
  • Added two new test cases for shadower and querybuilder each.

Why?

  • To integrate these options with the generate-shadow-test cli.

How did you test it?
tested locally and unit test.

Potential risks
NA. Maybe a few shadow tests will break if someone tries to use this option.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.18%. Comparing base (7f81710) to head (7a41ba2).

Additional details and impacted files
Files Coverage Δ
internal/query_builder.go 87.69% <100.00%> (+1.72%) ⬆️
internal/workflow_shadower.go 77.14% <100.00%> (+0.67%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f81710...7a41ba2. Read the comment docs.

@agautam478 agautam478 merged commit 73b12d5 into cadence-workflow:master May 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants