Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the registered workflows and activities getter APIs for testsuite #1343

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ketsiambaku
Copy link
Contributor

What changed?
Update TestActivityEnvironment with new APIs so that it implements the ActivityRegistry interface
Update TestWorkflowEnvironment with new APIs so that it implements the Registry interface

Why?

How did you test it?
unit tests

Potential risks

@ketsiambaku ketsiambaku marked this pull request as ready for review June 12, 2024 22:36
@ketsiambaku ketsiambaku changed the title Implement the registered workflows and activities APIs in testsuite Implement the registered workflows and activities getter APIs for testsuite Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.19%. Comparing base (13c2821) to head (86e6e56).

Additional details and impacted files

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c2821...86e6e56. Read the comment docs.

@ketsiambaku ketsiambaku merged commit 9a7e9b7 into cadence-workflow:master Jun 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants