Adjust startedCount assertion in Test_WorkflowLocalActivityWithMockAndListeners #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemort
requested review from
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
…dListeners Execution of the LocalActivities happens asynchronously from the workflow execution. If the local activity has already been canceled by the time it goes to start the activity then the started listener is never invoked, and the test observes only a single activity being started. This is valid as the Workflow is written so adjust the assertion against it.
taylanisikdemir
approved these changes
Jul 3, 2024
mrombout
pushed a commit
to softsense/cadence-client
that referenced
this pull request
Feb 26, 2025
…dListeners (cadence-workflow#1353) Execution of the LocalActivities happens asynchronously from the workflow execution. If the local activity has already been canceled by the time it goes to start the activity then the started listener is never invoked, and the test observes only a single activity being started. This is valid as the Workflow is written so adjust the assertion against it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execution of the LocalActivities happens asynchronously from the workflow execution. If the local activity has already been canceled by the time it goes to start the activity then the started listener is never invoked, and the test observes only a single activity being started. This is valid as the Workflow is written so adjust the assertion against it.
This seems to be happening more frequently after we migrated our CI, internal reference CDNC-9656
What changed?
Why?
How did you test it?
Potential risks