Skip to content

Commit

Permalink
Fix/workflow history loading spinner (#429)
Browse files Browse the repository at this point in the history
* fixed behaviour of spinner. Need to check tests also pass

* updated ready logic to only affect tests. wont change loading spinner logic
  • Loading branch information
just-at-uber committed Nov 19, 2021
1 parent 99ac0dc commit 96062a6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion client/containers/workflow/component.vue
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,9 @@ export default {
<section
class="execution"
:class="{
loading: wfLoading || history.loading,
loading:
wfLoading ||
(history.loading && (!historyEvents || !historyEvents.length)),
ready: !wfLoading && !history.loading,
}"
>
Expand Down

0 comments on commit 96062a6

Please sign in to comment.