Feature/refactor server router #290

just-at-uber · 2021-04-23T20:12:38Z

This PR has no functional change, only syntax / readability changes. The goal is to refactor Cadence UI server router so it has separate files for each route handler. This makes it easier to reason about what each handler is doing. Also each handler has no dependency on other handlers so there is no reason why they are in the same file. Because this PR is creating new files, majority of new lines are created from license headers per new file.

Changed

moved server/router.js route handlers into separate files in server/router/routes
moved server/helpers into server/router/helpers
moved helpers in server/router.js toserver/router/helpers

…plit out more helpers in router into helpers.

just-at-uber · 2021-04-23T20:12:56Z

server/router.js

@@ -1,422 +0,0 @@
-// Copyright (c) 2017-2021 Uber Technologies Inc.


file moved to server/router/index.js

just-at-uber · 2021-04-23T20:16:26Z

server/router/helpers/index.js

@@ -0,0 +1,34 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/helpers into server/router/handlers

just-at-uber · 2021-04-23T20:16:39Z

server/router/helpers/build-query-string.js

@@ -0,0 +1,37 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved helpers in server/router.js to server/router/handlers

just-at-uber · 2021-04-23T20:18:57Z

server/router/helpers/list-workflows.js

@@ -0,0 +1,46 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved helpers in server/router.js toserver/router/helpers

just-at-uber · 2021-04-23T20:19:51Z

server/router/helpers/map-history-response.js

@@ -0,0 +1,45 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved helpers in server/router.js toserver/router/helpers

just-at-uber · 2021-04-23T20:20:03Z

server/router/helpers/replacer.js

@@ -0,0 +1,33 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved helpers in server/router.js toserver/router/helpers

just-at-uber · 2021-04-23T20:20:40Z

server/router/index.js

@@ -0,0 +1,136 @@
+// Copyright (c) 2017-2021 Uber Technologies Inc.


file moved from server/router.js to server/router/index.js

just-at-uber · 2021-04-23T20:20:56Z

server/router/index.js

+  workflowQueryTypeHandler,
+  workflowSignalHandler,
+  workflowTerminateHandler,
+} = require('./routes');


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:21:31Z

server/router/routes/domain-authorization-handler.js

@@ -0,0 +1,30 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:21:36Z

server/router/routes/domain-handler.js

@@ -0,0 +1,26 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:21:40Z

server/router/routes/domain-list-handler.js

@@ -0,0 +1,31 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:21:44Z

server/router/routes/feature-flag-handler.js

@@ -0,0 +1,39 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:22:20Z

server/router/routes/health-handler.js

@@ -19,8 +19,6 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.

-const momentToLong = require('./moment-to-long');
+const healthHandler = ctx => (ctx.body = 'OK');


I think git diff messed up here. this is a new route handler.

just-at-uber · 2021-04-23T20:22:37Z

server/router/routes/index.js

@@ -0,0 +1,58 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:22:43Z

server/router/routes/tasklist-handler.js

@@ -0,0 +1,41 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:22:55Z

server/router/routes/tasklist-partition-list-handler.js

@@ -0,0 +1,31 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:23:05Z

server/router/routes/tasklist-poller-list-handler.js

@@ -0,0 +1,55 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:23:11Z

server/router/routes/workflow-archived-list-handler.js

@@ -0,0 +1,47 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:23:18Z

server/router/routes/workflow-export-handler.js

@@ -0,0 +1,46 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:23:25Z

server/router/routes/workflow-handler.js

@@ -0,0 +1,90 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:23:32Z

server/router/routes/workflow-history-handler.js

@@ -0,0 +1,37 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:23:42Z

server/router/routes/workflow-list-handler.js

@@ -0,0 +1,33 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:23:46Z

server/router/routes/workflow-query-handler.js

@@ -0,0 +1,41 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:23:50Z

server/router/routes/workflow-query-type-handler.js

@@ -0,0 +1,30 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:23:54Z

server/router/routes/workflow-signal-handler.js

@@ -0,0 +1,28 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

just-at-uber · 2021-04-23T20:23:59Z

server/router/routes/workflow-terminate-handler.js

@@ -0,0 +1,28 @@
+// Copyright (c) 2021 Uber Technologies Inc.


moved server/router.js route handlers into separate files in server/router/routes

mkolodezny

LGTM, the overall structure looks more clear now!

just-at-uber added 8 commits April 22, 2021 16:47

refactoring server

b2457b9

more refactoring

aec6f41

fix lint

896cb5a

moved router into its own folder. moved helpers into router folder. s…

4e8de81

…plit out more helpers in router into helpers.

Merge branch 'master' into feature/es-support

12989de

fix conflicts

6952a2e

moving code into separate files for route handlers

c17d10a

fix lint

366f3a5

just-at-uber commented Apr 23, 2021

View reviewed changes

just-at-uber marked this pull request as ready for review April 23, 2021 20:25

just-at-uber requested a review from a team April 23, 2021 20:26

mkolodezny approved these changes Apr 23, 2021

View reviewed changes

just-at-uber merged commit 71e1c1f into master Apr 23, 2021

just-at-uber deleted the feature/refactor-server-router branch April 23, 2021 20:35

just-at-uber mentioned this pull request May 27, 2021

v3.26.0 #332

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/refactor server router #290

Feature/refactor server router #290

just-at-uber commented Apr 23, 2021 •

edited

Loading

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021 •

edited

Loading

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

just-at-uber Apr 23, 2021

mkolodezny left a comment

		@@ -1,422 +0,0 @@
		// Copyright (c) 2017-2021 Uber Technologies Inc.

		@@ -0,0 +1,34 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,37 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,46 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,45 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,33 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,136 @@
		// Copyright (c) 2017-2021 Uber Technologies Inc.

		@@ -0,0 +1,30 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,26 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,31 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,39 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,58 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,41 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,55 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,47 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,90 @@
		// Copyright (c) 2021 Uber Technologies Inc.

		@@ -0,0 +1,28 @@
		// Copyright (c) 2021 Uber Technologies Inc.

Feature/refactor server router #290

Feature/refactor server router #290

Conversation

just-at-uber commented Apr 23, 2021 • edited Loading

Changed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

just-at-uber Apr 23, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkolodezny left a comment

Choose a reason for hiding this comment

just-at-uber commented Apr 23, 2021 •

edited

Loading

just-at-uber Apr 23, 2021 •

edited

Loading