Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/integration test workflow terminate #302

Merged
merged 29 commits into from
May 3, 2021
Merged

Fix/integration test workflow terminate #302

merged 29 commits into from
May 3, 2021

Conversation

just-at-uber
Copy link
Contributor

@just-at-uber just-at-uber commented May 3, 2021 •
edited
Loading

Fixed

  • Fixed failing integration tests for terminate feature. This was due to the test workflow would change to completed status before the test was able to assert the terminate button is enabled. Adding delay in fetch API now gives more time for the test to assert the status.

@just-at-uber
added ROUTE_PARAMS_DOMAIN getter
0db348b
@just-at-uber
moved update query into helper and added support for omitting empty q…
67ebab8 
…uery params.
@just-at-uber
Merge branch 'master' into feature/route-container-update
20dc8b2
@just-at-uber
fix lint
d2e5d4c
@just-at-uber
increase test timeout to avoid failure
e0733c2
@just-at-uber
increasing delay before checking element exists
b5a1428
@just-at-uber
check that button is enabled before clicking it
428287b
@just-at-uber
adding enabled check to similiar tests
f0bec9c
@just-at-uber
fix lint
bb43922
@just-at-uber
moving delay before the button appears
2e0c236
@just-at-uber
reducing delay. removing timeout
04d222a
@just-at-uber
removing delay
7354cb0
@just-at-uber
copying code from passing test
620eef6
@just-at-uber
adding assertion for element to not be disabled.
8fac775
@just-at-uber
fix lint
ddcf670
@just-at-uber
trying to allow test runner to retry multiple times before failing
a1a20d5
@just-at-uber
adjusting selector
7558555
@just-at-uber
trying to add check on element in a retry
08cdcbf
@just-at-uber
making similar tests more resiliant
c3d8b85
@just-at-uber
forcing diff change
e5a6749
@just-at-uber
adding options to summaryTest and withFullHistory and withHistory hel…
bce06b0 
…pers
@just-at-uber
Merge branch 'feature/route-container-update' into fix/integration-te…
8b4c2b9 
…st-wf-terminate
@just-at-uber
fix lint
cb4ce1e
@just-at-uber
make options specific to history
91bcc21
@just-at-uber
fixed issue with handler option set to false explicitly.
16db2bd
@just-at-uber
adding API delay for termination tests
2114eb3
@just-at-uber
fix lint
5c7d2df
@just-at-uber
reverting README change
7d6ff3f
@just-at-uber
reverting files unrelated to integration test changes
2ed9901
@just-at-uber just-at-uber marked this pull request as ready for review May 3, 2021 21:45
@just-at-uber just-at-uber requested a review from a team May 3, 2021 21:45
@just-at-uber just-at-uber merged commit a83ccff into master May 3, 2021
@just-at-uber just-at-uber deleted the fix/integration-test-wf-terminate branch May 3, 2021 22:03
@just-at-uber just-at-uber mentioned this pull request May 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@just-at-uber @yux0