Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wf list getter query string #315

Merged
merged 4 commits into from
May 19, 2021

Conversation

just-at-uber
Copy link
Contributor

@just-at-uber just-at-uber commented May 18, 2021

Changed

  • moved computed query string to getter

Added

  • WORKFLOW_LIST_QUERY_STRING getter

@@ -172,9 +173,6 @@ export default {
workflowName,
});
},
queryString() {
return this.$route.query.queryString || '';
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved computed query string to getter

@just-at-uber just-at-uber marked this pull request as ready for review May 18, 2021 23:35
@just-at-uber just-at-uber requested a review from a team May 18, 2021 23:35
@just-at-uber just-at-uber merged commit f42db51 into master May 19, 2021
@just-at-uber just-at-uber deleted the feature/wf-list-getter-query-string branch May 19, 2021 16:24
@just-at-uber just-at-uber mentioned this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants