Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/wf list action filter change #320

Merged
merged 2 commits into from
May 19, 2021
Merged

Feature/wf list action filter change #320

merged 2 commits into from
May 19, 2021

Conversation

just-at-uber
Copy link
Contributor

Changed

  • moved onFilterChange to action

Added

  • WORKFLOW_LIST_ON_FILTER_CHANGE action

just-at-uber
just-at-uber commented May 19, 2021
View reviewed changes
client/containers/workflow-list/component.vue

this.$router.replaceQueryParam(target.getAttribute('name'), target.value);
this.$emit('onFilterChange', { [name]: value });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved onFilterChange to action

@just-at-uber just-at-uber marked this pull request as ready for review May 19, 2021 23:12
@just-at-uber just-at-uber requested a review from a team May 19, 2021 23:13
@just-at-uber just-at-uber merged commit 9b0fc93 into master May 19, 2021
@just-at-uber just-at-uber deleted the feature/wf-list-action-filter-change branch May 19, 2021 23:13
@just-at-uber just-at-uber mentioned this pull request May 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkolodezny mkolodezny mkolodezny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@just-at-uber @mkolodezny