Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/server init params #330

Merged
merged 1 commit into from
May 26, 2021
Merged

Feature/server init params #330

merged 1 commit into from
May 26, 2021

Conversation

just-at-uber
Copy link
Contributor

Changed

  • moving request config and peers variables to be passed in as params in app init

@just-at-uber just-at-uber marked this pull request as ready for review May 26, 2021 18:52
@just-at-uber just-at-uber requested a review from a team May 26, 2021 18:53
mkolodezny
mkolodezny approved these changes May 26, 2021
View reviewed changes
Copy link

@mkolodezny mkolodezny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@just-at-uber just-at-uber merged commit c87ab9a into master May 26, 2021
@just-at-uber just-at-uber deleted the feature/server-init-params branch May 26, 2021 20:29
@just-at-uber just-at-uber mentioned this pull request May 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkolodezny mkolodezny mkolodezny approved these changes

@Shaddoll Shaddoll Shaddoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@just-at-uber @Shaddoll @mkolodezny