Feature/domain service #361
Conversation
…ow removed from cluster service to use cache manager instead.
There was a problem hiding this comment.
Overall looks good. I couldn't quite understand how this is gonna behave during an update as explained in the comment.
Another thing (not a blocker for this change) is to think about how to let user clear the cache when they are searching for a new domain. Something like
"Cache is updated at @timestamp" [Update Now]
would help user and also can avoid confusion if they can't figure out why their domain doesn't show up.
| }); | ||
| }); | ||
|
|
||
| describe('when nextPageToken is returned', () => { |
There was a problem hiding this comment.
do you need a case where the cache is updated and the result set changed during pagination?
There was a problem hiding this comment.
I don't think that case can occur in the same request.
so to put another way:
say request1 is using the cached version
following path from
server/router/services/domain-service/index.js
calls getDomainList which asks cacheManager if it needs new request or not to cadence server, it will simply return domainList which is cached.
Then continues to getMatchingDomains based on the querystring the user typed.
now say request2 occurs after cache period expires
calls getDomainList which asks cacheManager if it needs new request or not to cadence server, it will then fetch next page until nextPageToken returns undefined. then returns domain list and calls getMatchingDomains
There was a problem hiding this comment.
cadence-server will continue to paginate even if the result has changed since is my understanding
Added
DomainServicewhich allows searching for a domain with a partial/complete querystring.