Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/http service #364

Merged
merged 5 commits into from
Jul 23, 2021
Merged

Feature/http service #364

merged 5 commits into from
Jul 23, 2021

Conversation

just-at-uber
Copy link
Contributor

@just-at-uber just-at-uber commented Jul 21, 2021

Added

  • MockDate library which helps mock javascript date with a fixed date so that when integrations tests are run, the date is locked when the tests start and finishes. The date will reset once test is complete.

Changed

  • replaced $http with httpService so that services can access http as well as components and is consistent between the two.
  • getQueryStringFromObject to filter out keys with null or undefined values.
  • workflow component cleanup for fetching data
  • workflow component now adds a ready class when all fetching is complete. This change ensures workflow integration tests are not leaking requests between tests by using the ready class to start the testing phase.

Removed

  • $moment as this was not referenced anywhere in the code.

@just-at-uber just-at-uber marked this pull request as ready for review July 23, 2021 17:42
@just-at-uber just-at-uber requested a review from a team July 23, 2021 17:42
@just-at-uber just-at-uber merged commit c3eb3fe into master Jul 23, 2021
@just-at-uber just-at-uber deleted the feature/http-service branch July 23, 2021 18:49
@just-at-uber just-at-uber mentioned this pull request Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants