Feature/domain autocomplete getters #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-at-uber
changed the title
demirkayaender
approved these changes
Jul 26, 2021
Groxx
reviewed
Jul 26, 2021
| // THE SOFTWARE. | ||
|
|
||
| const combineDomainList = ({ domainList, visitedDomainList }) => { | ||
| const domainListUuidList = domainList.map(domain => domain.domainInfo.uuid); |
There was a problem hiding this comment.
how big do these lists get? are they prior to the 15-limit or after?
if it's prior to that limit, probably worth switching this to be a map lookup - 100s might be visibly slow to do repeated lookups on a list like this.
There was a problem hiding this comment.
Right now there is no cap on visitedDomainList so this can grow infinitely. I will change the action in the next PR (#369) to cap out to a max of 15.
Groxx
approved these changes
Jul 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
DomainAutocompletegetterscombinehelper which takesdata&callbacksas arguments which will pass data to first callback then passes output to next callback until the final callback returns the final output (similar to how middleware works).