Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/workflow list refactor #371

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Feature/workflow list refactor #371

merged 2 commits into from
Jul 27, 2021

Conversation

just-at-uber
Copy link
Contributor

@just-at-uber just-at-uber commented Jul 27, 2021 •
edited
Loading

Changed

  • Refactoring workflow list to watch for domain change and fetch workflow list for the new domain
  • Reordering functions to be alphabetical order

Fixed

  • Workflow list test which was not correctly waiting for ready state.

just-at-uber
just-at-uber commented Jul 27, 2021
View reviewed changes
client/containers/workflow-list/component.vue
await this.fetchDomain();
this.refreshWorkflows();
}
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring workflow list to watch for domain change and fetch workflow list for the new domain

@just-at-uber just-at-uber requested a review from a team July 27, 2021 19:15
@just-at-uber just-at-uber marked this pull request as ready for review July 27, 2021 19:15
@just-at-uber just-at-uber merged commit 290dad3 into master Jul 27, 2021
@just-at-uber just-at-uber deleted the feature/workflow-list-refactor branch July 27, 2021 19:54
@just-at-uber just-at-uber mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaddoll Shaddoll Shaddoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@just-at-uber @Shaddoll