Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/migrate recent domains #374

Merged
merged 5 commits into from
Jul 27, 2021
Merged

Feature/migrate recent domains #374

merged 5 commits into from
Jul 27, 2021

Conversation

just-at-uber
Copy link
Contributor

@just-at-uber just-at-uber commented Jul 27, 2021 •
edited
Loading

Added

  • migrateRecentDomains which will help migrate recent-domains cookie to convert to a domain object w/ name.

Changed

  • changed all instances where domain was being type asserted to string and updating to object only.
  • updated uuid checking if it is migrated from recent-domains
  • updated tests to use new format for strings to objects with only name.

@just-at-uber just-at-uber marked this pull request as ready for review July 27, 2021 21:56
@just-at-uber just-at-uber requested a review from a team July 27, 2021 21:56
@just-at-uber just-at-uber merged commit 9c1d83d into master Jul 27, 2021
@just-at-uber just-at-uber deleted the feature/migrate-recent-domains branch July 27, 2021 22:05
Groxx
Groxx approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@Groxx Groxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
good to know migrations are simple.

@just-at-uber just-at-uber mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demirkayaender demirkayaender demirkayaender approved these changes

@Groxx Groxx Groxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@just-at-uber @Groxx @demirkayaender