Better scrolling for workflows list #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
approved these changes
Jul 21, 2023
3vilhamster
reviewed
Jul 21, 2023
client/App.vue
Outdated
| main | ||
| position absolute | ||
| width 100% | ||
| body, main |
There was a problem hiding this comment.
Very strange to see CSS without brackets {}
I'd prefer to always have them.
There was a problem hiding this comment.
Checking if they had the styles of this section done this way on purpose or we can add them
3vilhamster
approved these changes
Jul 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal from this Changes was to add a horizontal scrollbar to be able to read the workflows table on narrow screens.
While working on that there was multiple issues with the existing scrollbars that made placing a new scroll bar harder.
So here are the fixes that is made to the scrollbars:
This PR fixes all the above + add a horizontal scrollbar for workflows page if page is smaller than 1000px
This is how it looks now: