Fix bug in Cadence Web where falsy values do not render correctly #529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes an issue with cadence-web where false/0 values in the activity result do not render correctly. This is due to a check in the
getJsonStringObject
helper function returning an empty string if the result is falsy. While this is the intended behaviour for null/undefined, we want to render other values (such as false and 0) correctly.This change makes the check for null/undefined in the
getJsonStringObject
function more explicit.As an aside, an unnecessary null check in the line below it is removed.
Test plan
Ran cadence-web locally and loaded a test workflow to ensure the output is as expected.
Before
After
To test null and undefined, I hardcoded the result:
To test the removal of the unnecessary null check, a unit test was added to ensure that the
getStringElipsis
util function returns the expected output.