Parse status query param to int #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhityamamallan
approved these changes
Mar 26, 2024
Assem-Hafez
added a commit
to Assem-Hafez/cadence-web
that referenced
this pull request
Mar 26, 2024
Co-authored-by: Assem Hafez <assem.a.hafez@gmail.com>
Assem-Uber
added a commit
that referenced
this pull request
Mar 27, 2024
* handle export for cross origin * lint fix * fix href for export btn * remove wrong query params to the export get * change export link to use onclick * fix blob content * parse status query param to int (#544) Co-authored-by: Assem Hafez <assem.a.hafez@gmail.com> * move chai-spies to dev dependecies * fix lint * preserve event target reference in the promise context * fix lint --------- Co-authored-by: Assem Hafez <137278762+Assem-Uber@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archival query params are taken from the url so they are treated as strings.
In order to send a correct archival query status needs to be an int so that it is sent without quotes surrounding it.
The fix is to parse the status to integers if possible while reading them from url & pass the parsed value to the query builder