Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table - fix typing for onSort function #739

Merged

Conversation

adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Nov 22, 2024

Summary

  • Make onSort required only if table config has at least 1 sortable column
  • Fix Table to render unsortable cells if sortBy is not passed when sortable is true for a column
  • Add helper type TableConfig for readability
  • Add unit tests for TableSortableHeadCell
  • Mock TableSortableHeadCell out in Table test

Test plan

Type checks succeeding locally + tested by modifying the config

@Assem-Uber Assem-Uber merged commit 3adb31a into cadence-workflow:release/4.0.0 Nov 22, 2024
1 check passed
@adhityamamallan adhityamamallan deleted the 3.5-optional-onsort branch November 25, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants