Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support workflow already completed error (#4123)
<!-- Describe what has changed in this PR --> **What changed?** When a workflow is completed, signals were returning EntityNotExistsError With this diff we will start returning WorkflowExecutionAlreadyCompletedError which is more descriptive to the user See https://t3.uberinternal.com/browse/CDNC-615 for more details <!-- Tell your future self why have you made these changes --> **Why?** This change helps differentiate non existing workflows vs completed workflows. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** *Unit tests:* `go test -v github.com/uber/cadence/service/history -run TestEngineSuite -testify.m TestSignalWorkflowExecution_Failed` `go test -v github.com/uber/cadence/service/history -run engine2Suite -testify.m TestRequestCancelWorkflowExecutionFail` <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is it notable for release? e.g. schema updates, configuration or data migration required? If so, please mention it, and also update CHANGELOG.md --> **Release notes** <!-- Is there any documentation updates should be made for config, https://cadenceworkflow.io/docs/operation-guide/setup/ ? If so, please open an PR in https://github.com/uber/cadence-docs --> **Documentation Changes**
- Loading branch information