Use getter function instead of dereference

cadence-workflow · Jan 10, 2018 · 48e40e2 · 48e40e2
1 parent 7a51af2
commit 48e40e2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 15 deletions.
diff --git a/common/persistence/cassandraPersistence.go b/common/persistence/cassandraPersistence.go
@@ -1494,8 +1494,8 @@ func (d *cassandraPersistence) CreateTasks(request *CreateTasksRequest) (*Create
 				rowTypeTask,
 				task.TaskID,
 				domainID,
-				*task.Execution.WorkflowId,
-				*task.Execution.RunId,
+				task.Execution.GetWorkflowId(),
+				task.Execution.GetRunId(),
 				scheduleID)
 		} else {
 			batch.Query(templateCreateTaskWithTTLQuery,
@@ -1505,8 +1505,8 @@ func (d *cassandraPersistence) CreateTasks(request *CreateTasksRequest) (*Create
 				rowTypeTask,
 				task.TaskID,
 				domainID,
-				*task.Execution.WorkflowId,
-				*task.Execution.RunId,
+				task.Execution.GetWorkflowId(),
+				task.Execution.GetRunId(),
 				scheduleID,
 				task.Data.ScheduleToStartTimeout)
 		}

diff --git a/service/matching/matchingEngine.go b/service/matching/matchingEngine.go
@@ -198,7 +198,7 @@ func (e *matchingEngineImpl) removeTaskListManager(id *taskListID) {
 
 // AddDecisionTask either delivers task directly to waiting poller or save it into task list persistence.
 func (e *matchingEngineImpl) AddDecisionTask(addRequest *m.AddDecisionTaskRequest) error {
-	domainID := *addRequest.DomainUUID
+	domainID := addRequest.GetDomainUUID()
 	taskListName := *addRequest.TaskList.Name
 	e.logger.Debugf("Received AddDecisionTask for taskList=%v, WorkflowID=%v, RunID=%v, ScheduleToStartTimeout=%v",
 		addRequest.TaskList.GetName(), addRequest.Execution.GetWorkflowId(), addRequest.Execution.GetRunId(),
@@ -210,18 +210,18 @@ func (e *matchingEngineImpl) AddDecisionTask(addRequest *m.AddDecisionTaskReques
 	}
 	taskInfo := &persistence.TaskInfo{
 		DomainID:               domainID,
-		RunID:                  *addRequest.Execution.RunId,
-		WorkflowID:             *addRequest.Execution.WorkflowId,
-		ScheduleID:             *addRequest.ScheduleId,
-		ScheduleToStartTimeout: *addRequest.ScheduleToStartTimeoutSeconds,
+		RunID:                  addRequest.Execution.GetRunId(),
+		WorkflowID:             addRequest.Execution.GetWorkflowId(),
+		ScheduleID:             addRequest.GetScheduleId(),
+		ScheduleToStartTimeout: addRequest.GetScheduleToStartTimeoutSeconds(),
 	}
 	return tlMgr.AddTask(addRequest.Execution, taskInfo)
 }
 
 // AddActivityTask either delivers task directly to waiting poller or save it into task list persistence.
 func (e *matchingEngineImpl) AddActivityTask(addRequest *m.AddActivityTaskRequest) error {
-	domainID := *addRequest.DomainUUID
-	sourceDomainID := *addRequest.SourceDomainUUID
+	domainID := addRequest.GetDomainUUID()
+	sourceDomainID := addRequest.GetSourceDomainUUID()
 	taskListName := *addRequest.TaskList.Name
 	e.logger.Debugf("Received AddActivityTask for taskList=%v WorkflowID=%v, RunID=%v",
 		taskListName, addRequest.Execution.WorkflowId, addRequest.Execution.RunId)
@@ -232,10 +232,10 @@ func (e *matchingEngineImpl) AddActivityTask(addRequest *m.AddActivityTaskReques
 	}
 	taskInfo := &persistence.TaskInfo{
 		DomainID:               sourceDomainID,
-		RunID:                  *addRequest.Execution.RunId,
-		WorkflowID:             *addRequest.Execution.WorkflowId,
-		ScheduleID:             *addRequest.ScheduleId,
-		ScheduleToStartTimeout: *addRequest.ScheduleToStartTimeoutSeconds,
+		RunID:                  addRequest.Execution.GetRunId(),
+		WorkflowID:             addRequest.Execution.GetWorkflowId(),
+		ScheduleID:             addRequest.GetScheduleId(),
+		ScheduleToStartTimeout: addRequest.GetScheduleToStartTimeoutSeconds(),
 	}
 	return tlMgr.AddTask(addRequest.Execution, taskInfo)
 }