Check identity length before RespondDecisionTaskCompleted to history (#…

…4215)
cadence-workflow · May 24, 2021 · edfb9ed · edfb9ed
1 parent 7e333a8
commit edfb9ed
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/service/frontend/workflowHandler.go b/service/frontend/workflowHandler.go
@@ -1564,20 +1564,20 @@ func (wh *WorkflowHandler) RespondDecisionTaskCompleted(
 		return nil, errShuttingDown
 	}
 
-	histResp, err := wh.GetHistoryClient().RespondDecisionTaskCompleted(ctx, &types.HistoryRespondDecisionTaskCompletedRequest{
-		DomainUUID:      taskToken.DomainID,
-		CompleteRequest: completeRequest},
-	)
-	if err != nil {
-		return nil, wh.error(err, scope)
-	}
-
 	if !common.ValidIDLength(
 		completeRequest.GetIdentity(),
 		scope,
 		wh.config.MaxIDLengthWarnLimit(),
 		wh.config.IdentityMaxLength(domainName),
 		metrics.CadenceErrIdentityExceededWarnLimit) {
+		return nil, wh.error(errIdentityTooLong, scope)
+	}
+
+	histResp, err := wh.GetHistoryClient().RespondDecisionTaskCompleted(ctx, &types.HistoryRespondDecisionTaskCompletedRequest{
+		DomainUUID:      taskToken.DomainID,
+		CompleteRequest: completeRequest},
+	)
+	if err != nil {
 		return nil, wh.normalizeVersionedErrors(ctx, wh.error(err, scope))
 	}