Simplify tags #3923
Merged
Simplify tags #3923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiliang86
approved these changes
Jan 26, 2021
mkolodezny
approved these changes
Jan 26, 2021
Just noticed while skimming that this file seemed drastically over-complicated. As the keys are all consts, this should mean that the net change for all this is that these take one slice pointer more space per instance. Separately, now that it's simpler, some of the variations are more noticeable. It may be worth standardizing further, e.g.: - sanitizing everything (except perhaps the kafka partition) - get rid of the "unknown" constructors? I can see them having some use, but it seems kinda random what has it and what doesn't.
github-actions bot
pushed a commit
to vytautas-karpavicius/cadence
that referenced
this pull request
Feb 4, 2021
I just noticed while skimming that this file seemed drastically over-complicated. As the keys are all consts, this should mean that the net change for all this is that these take one slice pointer more space per instance. And binary size is marginally smaller due to fewer types / a smaller type->interface lookup table. Separately, now that it's simpler, some of the variations are more noticeable. It may be worth standardizing further, e.g.: - sanitizing everything (except perhaps the kafka partition) - get rid of the "unknown" constructors? I can see them having some use, but it seems kinda random what has it and what doesn't.
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
I just noticed while skimming that this file seemed drastically over-complicated. As the keys are all consts, this should mean that the net change for all this is that these take one slice pointer more space per instance. And binary size is marginally smaller due to fewer types / a smaller type->interface lookup table. Separately, now that it's simpler, some of the variations are more noticeable. It may be worth standardizing further, e.g.: - sanitizing everything (except perhaps the kafka partition) - get rid of the "unknown" constructors? I can see them having some use, but it seems kinda random what has it and what doesn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed while skimming that this file seemed drastically over-complicated.
As the keys are all consts, this should mean that the net change for all this is that these take one slice pointer more space per instance. And binary size is slightly smaller due to fewer types / a smaller type->interface lookup table.
Separately, now that it's simpler, some of the variations are more noticeable.
It may be worth standardizing further, e.g.: