Drop pointer for forwarded from fields #3942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groxx
approved these changes
Jan 29, 2021
| ForwardedFrom: t.ForwardedFrom, | ||
| ForwardedFrom: &t.ForwardedFrom, |
There was a problem hiding this comment.
I assume this is all internal, so no concerns about old things that won't send this?
There was a problem hiding this comment.
Yes this is internal only.
But important thing for this and related PRs is the actual usage of these fields. Most of them are used through Get... wrappers anyway. So the logic does not change as the code using them always receive empty string (even if it was nil originally). Therefore with these changes we only move nil to empty conversion to a different place.
Only in occasions where field is explicitly checked for nil value, we should pay attention, whether some optionality semantics were intended there.
github-actions bot
pushed a commit
to vytautas-karpavicius/cadence
that referenced
this pull request
Feb 4, 2021
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Drop pointer for forwarded from fields within internal types.
Why?
This is one of PRs planned to drop pointers for always required fields in internal types. It will make them more idiomatic and easier to use. These pointer are legacy of Thrift types that were used previously through our codebase. This will also allow safer migration to grpc, as proto primitive types don't have nils by default.
How did you test it?
Passing build and existing tests.
Potential risks