Drop pointer for activity id fields #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groxx
reviewed
Feb 4, 2021
host/integration_test.go
Outdated
| @@ -2431,7 +2431,7 @@ func (s *integrationSuite) TestDecisionTaskFailed() { | |||
| return nil, []*types.Decision{{ | |||
| DecisionType: types.DecisionTypeScheduleActivityTask.Ptr(), | |||
| ScheduleActivityTaskDecisionAttributes: &types.ScheduleActivityTaskDecisionAttributes{ | |||
| ActivityID: common.StringPtr(strconv.Itoa(int(1))), | |||
| ActivityID: strconv.Itoa(int(1)), | |||
There was a problem hiding this comment.
"1" though obviously minor (same with line 2610)
Groxx
reviewed
Feb 4, 2021
host/queryworkflow_test.go
Outdated
| @@ -86,7 +86,7 @@ func (s *integrationSuite) TestQueryWorkflow_Sticky() { | |||
| return nil, []*types.Decision{{ | |||
| DecisionType: types.DecisionTypeScheduleActivityTask.Ptr(), | |||
| ScheduleActivityTaskDecisionAttributes: &types.ScheduleActivityTaskDecisionAttributes{ | |||
| ActivityID: common.StringPtr(strconv.Itoa(int(1))), | |||
| ActivityID: strconv.Itoa(int(1)), | |||
Groxx
reviewed
Feb 4, 2021
| @@ -82,7 +82,7 @@ func (s *integrationSuite) TestResetWorkflow() { | |||
| scheduleActivityCommands = append(scheduleActivityCommands, &types.Decision{ | |||
| DecisionType: types.DecisionTypeScheduleActivityTask.Ptr(), | |||
| ScheduleActivityTaskDecisionAttributes: &types.ScheduleActivityTaskDecisionAttributes{ | |||
| ActivityID: common.StringPtr(strconv.Itoa(i)), | |||
| ActivityID: strconv.Itoa(i), | |||
There was a problem hiding this comment.
"1"... and other files. meh. you get the idea.
truly, I think this is fine to leave unless you're excited about changing them. there are far larger issues with these tests than a sub-optimal string creation, and it's not actually related to this PR.
There was a problem hiding this comment.
Yep, fixed all of those.
Groxx
approved these changes
Feb 4, 2021
github-actions bot
pushed a commit
to vytautas-karpavicius/cadence
that referenced
this pull request
Feb 4, 2021
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Drop pointer for activity id fields within internal types.
Why?
This is one of PRs planned to drop pointers for always required fields in internal types. It will make them more idiomatic and easier to use. These pointer are legacy of Thrift types that were used previously through our codebase. This will also allow safer migration to grpc, as proto primitive types don't have nils by default.
How did you test it?
Passing build and existing tests.
Potential risks