Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pick child workflow id check #3994

Merged
merged 2 commits into from
Feb 19, 2021
Merged

pick child workflow id check #3994

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f63d221
pick child workflow id check
yux0 Feb 18, 2021
3037490
update header
yux0 Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion service/history/historyEngine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// Copyright (c) 2017 Uber Technologies, Inc.
// Copyright (c) 2017-2021 Uber Technologies, Inc.
// Portions of the Software are attributed to Copyright (c) 2021 Temporal Technologies Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -2399,6 +2400,9 @@ func (e *historyEngineImpl) RecordChildExecutionCompleted(
if !isRunning || ci.StartedID == common.EmptyEventID {
return &types.EntityNotExistsError{Message: "Pending child execution not found."}
}
if ci.StartedWorkflowID != completedExecution.GetWorkflowID() {
return &types.EntityNotExistsError{Message: "Pending child execution not found."}
}

switch *completionEvent.EventType {
case types.EventTypeWorkflowExecutionCompleted:
Expand Down