Drop pointer for shard id fields #3996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Feb 18, 2021
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Dropping pointer for shard id fields.
This change have an implication that failing to specify shard id in the request, will default to zero shard. ShardID=0 is a valid shard in cadence see here. This is not a huge issue as all those fields are within internal APIs which we can control.
An alternative solution could be to update proto IDLs to make shard_id optional by wrapping it with either
google.protobuf.Int32Valueor introducing separate wrapper message for it, such asShardID.Why?
To revise internal types for more idiomatic use and prepare for proto conversion.
How did you test it?
Existing tests.
Potential risks
Future changes that fails to specify required shard id will be interpreted as shard 0.