Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop pointer for DomainTaskAttributes fields #4003

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Drop pointer for DomainTaskAttributes fields #4003

merged 2 commits into from
Feb 22, 2021

Conversation

vytautas-karpavicius
Copy link
Contributor

Drop pointers for DomainTaskAttributes fields within internal types.

@vytautas-karpavicius vytautas-karpavicius requested a review from a team February 19, 2021 15:55
@vytautas-karpavicius vytautas-karpavicius marked this pull request as ready for review February 19, 2021 15:55
@coveralls
Copy link

coveralls commented Feb 19, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 64.589% when pulling 713a56a on vytautas-karpavicius:drop-ptr-domain-task-attributes into c6d962e on uber:master.

yycptt
yycptt approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure if @yux0 wants to take another look.

@vytautas-karpavicius vytautas-karpavicius merged commit 0035139 into cadence-workflow:master Feb 22, 2021
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
@vytautas-karpavicius @yux0
Drop pointer for DomainTaskAttributes fields (cadence-workflow#4003)
435accc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yycptt yycptt yycptt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vytautas-karpavicius @coveralls @yycptt