Move workflow utility components to separate package #4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Feb 25, 2021
service/history/workflow/util.go
Outdated
| @@ -272,12 +288,11 @@ func GetActiveDomainEntry( | |||
| domainUUID string, | |||
There was a problem hiding this comment.
Can this move to shard context?
There was a problem hiding this comment.
+1
This would makes more sense as it does not have anything workflow related.
There was a problem hiding this comment.
Yeah, I was thinking probably this should be moved to domain package instead of shard as it has not much to do with shard, which is only for getting the domain cache.
There was a problem hiding this comment.
Synced with @yux0 offline. So GetActivityDomainEntry now is a method of the DomainCache interface and ValidateDomainUUID is moved to common package.
yux0
approved these changes
Feb 25, 2021
yycptt
force-pushed
the
workflow-util-package
branch
from
5c268c6 to
b5e4baa
Compare
yycptt
force-pushed
the
workflow-util-package
branch
from
3ee8e16 to
1e0e3f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
#3181
How did you test it?
Existing tests.
Potential risks
Risk is minimal as it only moves code around.