Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the poller count metric #4020

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Conversation

mkolodezny
Copy link
Contributor

What changed?
clean the expired pollers before reporting the metric

Why?
follow up on #3918

How did you test it?
tested locally

@coveralls
Copy link

coveralls commented Feb 25, 2021

Coverage Status

Coverage decreased (-0.02%) to 64.599% when pulling 024b236 on mkolodezny:poller into 0921bf5 on uber:master.

@mkolodezny mkolodezny marked this pull request as ready for review February 26, 2021 01:54
Copy link
Contributor

@mantas-sidlauskas mantas-sidlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smgt

service/matching/pollerHistory.go Outdated Show resolved Hide resolved
service/matching/taskListManager.go Show resolved Hide resolved
@mkolodezny mkolodezny merged commit c0f1252 into cadence-workflow:master Feb 26, 2021
@mkolodezny mkolodezny deleted the poller branch February 26, 2021 17:51
mkolodezny added a commit that referenced this pull request Feb 26, 2021
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants