Add compose file for multi-cluster setup #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Mar 3, 2021
| environment: | ||
| - "CASSANDRA_SEEDS=cassandra" | ||
| - "STATSD_ENDPOINT=statsd:8125" | ||
| - "DYNAMIC_CONFIG_FILE_PATH=config/dynamicconfig/development.yaml" |
There was a problem hiding this comment.
The replication has to be config from the yaml file. Take a look at the development_active.yaml and development_standby.yaml
There was a problem hiding this comment.
Yes, it uses config_template.yaml to generate config file. This environment variable is set to get dynamic config.
There was a problem hiding this comment.
Oh, I see. This is a dynamic config yaml. Then it looks good to me.
yux0
approved these changes
Mar 3, 2021
longquanzheng
suggested changes
Mar 3, 2021
yycptt
approved these changes
Mar 3, 2021
Comment on lines
+38
to
+41
| - "7943:7933" | ||
| - "7944:7934" | ||
| - "7945:7935" | ||
| - "7949:7939" |
There was a problem hiding this comment.
nit: Can we make the port number consistent with those in development_standby.yaml? Makes it a bit easier when switching back and forth between different setup.
bootstrapHosts: [ "127.0.0.1:8933", "127.0.0.1:8934", "127.0.0.1:8935", "127.0.0.1:8940" ]
longquanzheng
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add compose file for multi-cluster setup
Why?
It makes it easier for us to run cadence with 2 clusters on laptop.
How did you test it?
Potential risks