Enforce context timeout in matching AddTask #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
One path in AddTask in matching requires persist the task to DB, and may be retried for up to 30 second regardless what context timeout in specified for the AddTask call.
On history side, the specified context timeout is only 3s, after will retry the AddTask operation if failed. This mismatch of retry policy will cause matching to persist much more tasks than needed, and made the situation worse when service busy error happens.
By enforcing the context timeout when persisting tasks, we removed mismatching in two different retry policies and can reduce the number of tasks persisted by matching.
How did you test it?
Unit test
Potential risks
More matching Add task error may happen as now context timeout is enforced.