ship history event diff with sticky task #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarabbas
approved these changes
Nov 7, 2017
service/frontend/handler.go
Outdated
| @@ -391,9 +391,16 @@ func (wh *WorkflowHandler) PollForDecisionTask( | |||
| if matchingResp.WorkflowExecution != nil { | |||
| // Non-empty response. Get the history | |||
| nextEventID := common.Int64Default(matchingResp.StartedEventId) + 1 | |||
| firstEventID := common.FirstEventID | |||
| if matchingResp.StickyExecutionEnabled != nil && | |||
There was a problem hiding this comment.
Why can't you use the generated getter?
yiminc-zz
force-pushed
the
partial_history
branch
from
709c416 to
7827844
Compare
|
Changes Unknown when pulling 7827844 on yiminc:partial_history into ** on uber:master**. |
|
i think you can merge the changes from https://github.com/uber/cadence/pull/407/files common/persistence/cassandraHistoryPersistence.go line 195-197 and common/persistence/cassandraHistoryPersistence_test.go to this PR |
yiminc-zz
force-pushed
the
partial_history
branch
from
7827844 to
9fa18fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ship partial history with decision task. For query task, it won't use sticky task list, and will continue to ship full history. This will be addressed separately. #405