Fix domain registration error handling in cassandra #4066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Mar 23, 2021
yux0
approved these changes
Mar 23, 2021
yycptt
force-pushed
the
fix-domain-register
branch
from
6213ef3
to
e54fefe
Compare
mkolodezny
reviewed
Mar 23, 2021
common/persistence/persistence-tests/metadataPersistenceV2Test.go
Outdated
Show resolved
Hide resolved
mkolodezny
reviewed
Mar 23, 2021
yycptt
force-pushed
the
fix-domain-register
branch
from
a8cea98
to
4c344de
Compare
yux0
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix domain registration error handling in cassandra
Why?
DomainAlreadyExists error may be returned even if the domain is not actually registered when there's concurrent domain registration requests due to CAS failure on domain metadata.
How did you test it?
Persistence unit test
Potential risks