Add a domain cluster filter during replication #4069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
replication_filter
branch
from
97974c8
to
e0507f7
Compare
Pull Request Test Coverage Report for Build aa4a66e4-8655-4a62-be0b-fd31c3e1a40c
💛 - Coveralls |
mkolodezny
reviewed
Mar 24, 2021
| @@ -155,14 +156,23 @@ func (t *taskAckManagerImpl) GetTasks( | |||
| readLevel := lastReadTaskID | |||
| TaskInfoLoop: | |||
| for _, taskInfo := range taskInfoList { | |||
| // filter task info by domain clusters. | |||
| domainEntity, err := t.shard.GetDomainCache().GetDomainByID(taskInfo.GetDomainID()) | |||
There was a problem hiding this comment.
do we assume here the domain from the db is always in the cache?
There was a problem hiding this comment.
Yes. Domains are always in cache
mkolodezny
reviewed
Mar 24, 2021
| @@ -614,6 +624,15 @@ func (t *taskAckManagerImpl) generateHistoryReplicationTask( | |||
| ) | |||
| } | |||
|
|
|||
| func skipTask(pollingCluster string, domainEntity *cache.DomainCacheEntry) bool { | |||
| for _, cluster := range domainEntity.GetReplicationConfig().Clusters { | |||
github-actions
bot
force-pushed
the
replication_filter
branch
2 times, most recently
from
09148e9
to
4afae88
Compare
github-actions
bot
force-pushed
the
replication_filter
branch
from
11f8cf2
to
7363573
Compare
yycptt
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add a domain cluster filter during replication
Why?
Save one DB call to fetch workflow history in replication
How did you test it?
Unit tests
Potential risks
N/A