Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version to Kafka config #4072

Merged
merged 15 commits into from
Apr 6, 2021
Merged

Add version to Kafka config #4072

merged 15 commits into from
Apr 6, 2021

Conversation

mistikel
Copy link
Contributor

What changed?
Expose Kafka version for configuration

Why?
This need to be allowed to configured, so that Cadence can work with different versions of Kafka.

How did you test it?

Potential risks
Breaking changes if the config is not updated

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

longquanzheng
longquanzheng approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@longquanzheng longquanzheng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@longquanzheng longquanzheng changed the title add sarama version to config Add version to Kafka config Mar 24, 2021
@longquanzheng longquanzheng mentioned this pull request Mar 24, 2021
Closed
@mistikel
Copy link
Contributor Author

@longquanzheng @mkolodezny any update?

longquanzheng
longquanzheng suggested changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, one more.

longquanzheng
longquanzheng approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution.
it LGTM now.

@mkolodezny let us know if you have other comments.

@coveralls
Copy link

coveralls commented Mar 30, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 3324476d-1e0e-4a77-859a-bc2136a3699d

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.05%) to 68.004%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/messaging/kafka/clientImpl.go 9 11 81.82%
Files with Coverage Reduction New Missed Lines %
host/signalworkflowTest.go 1 95.53%
common/membership/rpServiceResolver.go 2 73.58%
service/history/execution/mutable_state_builder.go 2 69.85%
service/history/queue/timer_queue_processor.go 2 58.77%
common/cache/lru.go 3 90.73%
Totals Coverage Status
Change from base Build d1a61183-daf0-4e2c-bfde-0612f7102335: 0.05%
Covered Lines: 98701
Relevant Lines: 145140
💛 - Coveralls

@longquanzheng longquanzheng merged commit 2a7b75d into cadence-workflow:master Apr 6, 2021
@mistikel mistikel deleted the sarama-version branch April 6, 2021 01:26
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
@mistikel @yux0
Add version to Kafka config (cadence-workflow#4072)
eac4678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkolodezny mkolodezny mkolodezny left review comments

@yux0 yux0 yux0 approved these changes

@longquanzheng longquanzheng longquanzheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mistikel @CLAassistant @coveralls @yux0 @longquanzheng @mkolodezny @meiliang86