Fix emit 0 count if encounters error #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Mar 24, 2021
Pull Request Test Coverage Report for Build 0441c53f-563c-4967-85ee-09b31a74a011
💛 - Coveralls |
github-actions
bot
force-pushed
the
domain_dlq
branch
from
8d60e66 to
059d02d
Compare
mkolodezny
reviewed
Mar 25, 2021
| @@ -336,13 +336,14 @@ func (q *replicationQueueImpl) emitDLQSize() { | |||
| ).IncCounter( | |||
| metrics.DomainReplicationQueueSizeErrorCount, | |||
| ) | |||
| } else { | |||
| q.metricsClient.Scope( | |||
There was a problem hiding this comment.
is there the corresponding metric on the dash?
mkolodezny
reviewed
Mar 25, 2021
| } | ||
| q.metricsClient.Scope( |
There was a problem hiding this comment.
nit: lets make sure it wont make the existing alerts going off.
There was a problem hiding this comment.
I updated the alert to use this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix emit 0 count if encounters error
Why?
Fix emit 0 count if encounters error
How did you test it?
Potential risks