Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options to config_template for docker image #4084

Conversation

peaaceChoi
Copy link
Contributor

What changed?
for #3870

  • Add more options to config_template for docker image
    • FRONTEND_PORT
    • MATCHING_PORT
    • WORKER_PORT
    • HISTORY_PORT
    • VISIBILITY_NAME
    • ES_PORT

Why?
It is more convenient if a config_template is provided dynamically. In my case, some ports were already assigned to other services.

How did you test it?
Local test

Potential risks
It doesn't matter as it supports default values.

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2021

CLA assistant check
All committers have signed the CLA.

@meiliang86 meiliang86 requested review from a team and longquanzheng March 29, 2021 17:23
Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker/config_template.yaml Outdated Show resolved Hide resolved
docker/config_template.yaml Outdated Show resolved Hide resolved
docker/config_template.yaml Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Mar 29, 2021

Pull Request Test Coverage Report for Build eef5242d-c966-4b5f-b991-364919f6e209

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.07%) to 65.177%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 78.6%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/queue/timer_queue_processor.go 2 58.77%
Totals Coverage Status
Change from base Build ca0505cb-e6e3-45e7-9ed9-6bd9e3c4a81a: 0.07%
Covered Lines: 86094
Relevant Lines: 132093

💛 - Coveralls

Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, what I meant is to change the BIND_ON_IP in publicClient, not others

docker/config_template.yaml Outdated Show resolved Hide resolved
docker/config_template.yaml Outdated Show resolved Hide resolved
docker/config_template.yaml Outdated Show resolved Hide resolved
docker/config_template.yaml Outdated Show resolved Hide resolved
@peaaceChoi
Copy link
Contributor Author

@longquanzheng I understood the details of bind-ip, Thanks for your review. :)

@longquanzheng
Copy link
Contributor

@peaaceChoi can you sign the CLA? thanks

@longquanzheng
Copy link
Contributor

@longquanzheng I understood the details of bind-ip, Thanks for your review. :)

Thanks for your contribution. But the CLA is required to merge.

@peaaceChoi
Copy link
Contributor Author

peaaceChoi commented Mar 31, 2021

@longquanzheng Sure, I approved it.

@meiliang86 meiliang86 requested a review from a team April 1, 2021 02:57
@longquanzheng longquanzheng merged commit 0bc3681 into cadence-workflow:master Apr 6, 2021
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
pregnor added a commit to banzaicloud/banzai-charts that referenced this pull request May 31, 2021
pregnor added a commit to banzaicloud/banzai-charts that referenced this pull request May 31, 2021
pregnor added a commit to banzaicloud/banzai-charts that referenced this pull request May 31, 2021
pregnor added a commit to banzaicloud/banzai-charts that referenced this pull request May 31, 2021
pregnor added a commit to banzaicloud/banzai-charts that referenced this pull request May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants