-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more options to config_template for docker image #4084
Add more options to config_template for docker image #4084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Test Coverage Report for Build eef5242d-c966-4b5f-b991-364919f6e209
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, what I meant is to change the BIND_ON_IP
in publicClient
, not others
@longquanzheng I understood the details of |
@peaaceChoi can you sign the CLA? thanks |
Thanks for your contribution. But the CLA is required to merge. |
@longquanzheng Sure, I approved it. |
What changed?
for #3870
Why?
It is more convenient if a config_template is provided dynamically. In my case, some ports were already assigned to other services.
How did you test it?
Local test
Potential risks
It doesn't matter as it supports default values.