Refactor config: move config and dynamiconfig one level up #4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
qlong-config-refactor
branch
from
84eb827 to
c5d0d3b
Compare
longquanzheng
force-pushed
the
qlong-config-refactor
branch
from
706722f to
5e012a0
Compare
yycptt
approved these changes
Apr 9, 2021
yycptt
reviewed
Apr 9, 2021
nvm, I confused the import path with the actual config file path. Change LGTM! |
longquanzheng
force-pushed
the
qlong-config-refactor
branch
from
6d42920 to
27d31e0
Compare
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactor config: move config and dynamiconfig one level up
Why?
I have been sick with this layout for a very long time. This config and dynamicconfig is one of the most frequent lookup but they are hidden very deep. Moreover, I don't know why they have to be under
service/.So of course services use the configs...but so are all other packages.
How did you test it?
existing test.
Mostly are done by IDE, I only need to fix something that IDE missed.
Potential risks
No.
Release notes
Documentation Changes