Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve shadow workflow #4144

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Improve shadow workflow #4144

merged 2 commits into from
Apr 19, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Apr 19, 2021

What changed?

  • Decrease default scan workflow page size
  • Decrease default max shadow count per run
  • Set replay activity start to close timeout based on # of workflow needs to be replayed
  • Enable shadower decision worker by default

Why?

How did you test it?
Existing test.

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested a review from yux0 April 19, 2021 19:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7882d536-363e-4a7a-ae42-3bc5234fd57e

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • 37 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.03%) to 67.105%
Files with Coverage Reduction New Missed Lines %
service/history/handler.go 2 46.59%
service/matching/taskListManager.go 2 74.72%
common/task/weightedRoundRobinTaskScheduler.go 3 89.64%
common/types/history.go 4 24.69%
service/history/historyEngine.go 4 70.81%
common/persistence/cassandra/cassandraTaskPersistence.go 22 59.16%
Totals Coverage Status
Change from base Build b9bac8da-8ee8-4688-8871-cac90eb5cbe3: 0.03%
Covered Lines: 98339
Relevant Lines: 146546
💛 - Coveralls

@yycptt yycptt merged commit 7057e5e into cadence-workflow:master Apr 19, 2021
@yycptt yycptt deleted the shadow-workflow-improvement branch April 19, 2021 22:58
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
@yycptt @yux0
Improve shadow workflow (cadence-workflow#4144)
a6a11cb 
- Decrease default scan workflow page size
- Decrease default max shadow count per run
- Set replay activity start to close timeout based on # of workflow needs to be replayed
- Enable shadower decision worker by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yycptt @coveralls @yux0