Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set grpc ports in docker config template #4146

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Apr 19, 2021

What changed?
Set grpc ports in docker config template

Why?
Fix GRPC port not configured for service error

How did you test it?
Tested locally

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested review from vytautas-karpavicius and a team April 19, 2021 19:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build a31f1dfd-6802-4d49-987c-2a083acf9cd3

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 64 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.02%) to 67.093%

Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
common/task/fifoTaskScheduler.go 2 82.47%
service/history/handler.go 2 46.74%
service/matching/taskListManager.go 2 74.72%
common/persistence/cassandra/cassandraPersistence.go 3 52.8%
common/types/history.go 4 24.69%
service/history/historyEngine.go 4 71.19%
service/history/execution/mutable_state_task_refresher.go 15 71.18%
common/persistence/cassandra/cassandraPersistenceUtil.go 31 90.87%
Totals Coverage Status
Change from base Build b9bac8da-8ee8-4688-8871-cac90eb5cbe3: 0.02%
Covered Lines: 98321
Relevant Lines: 146545

💛 - Coveralls

@yycptt yycptt merged commit 04f16e7 into cadence-workflow:master Apr 19, 2021
@yycptt yycptt deleted the grpc-docker-config-template branch April 19, 2021 20:28
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
pregnor added a commit to banzaicloud/banzai-charts that referenced this pull request May 31, 2021
pregnor added a commit to banzaicloud/banzai-charts that referenced this pull request May 31, 2021
pregnor added a commit to banzaicloud/banzai-charts that referenced this pull request May 31, 2021
pregnor added a commit to banzaicloud/banzai-charts that referenced this pull request May 31, 2021
pregnor added a commit to banzaicloud/banzai-charts that referenced this pull request May 31, 2021
pregnor added a commit to banzaicloud/banzai-charts that referenced this pull request May 31, 2021
pregnor added a commit to banzaicloud/banzai-charts that referenced this pull request May 31, 2021
pregnor added a commit to banzaicloud/banzai-charts that referenced this pull request May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants