Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout idls if folder is empty #4155

Closed
wants to merge 2 commits into from
Closed

Checkout idls if folder is empty #4155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf05388
apply approach from comment
longquanzheng Apr 25, 2021
73f728f
skip thrift too
longquanzheng Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ THRIFT_GEN := $(subst idls/thrift/,.build/,$(THRIFT_FILES))

# thrift is done when all sub-thrifts are done
$(BUILD)/thrift: $(THRIFT_GEN) | $(BUILD)
$(if $(THRIFT_GEN),,$(error "idls directory is empty, please use 'git submodule update idls/' to checkout submodule and retry")) # thrift_gen or thrift_files, either should work fine
@touch $@

# how to generate each thrift book-keeping file.
Expand Down Expand Up @@ -253,6 +254,7 @@ $(BUILD)/protoc: $(PROTO_FILES) $(BIN)/$(PROTOC_VERSION_BIN) $(BIN)/protoc-gen-g
.fake-thrift: | $(BIN) $(BUILD)
touch $(BIN)/thriftrw $(BIN)/thriftrw-plugin-yarpc
$(if $(THRIFT_GEN),touch $(THRIFT_GEN),) # maybe ignoring empty idl folder
touch $(BUILD)/thrift #skip thrift too

# ====================================
# other intermediates
Expand Down