Update workflow execution metrics #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
changed the title
Shaddoll
force-pushed
the
transaction-metrics
branch
6 times, most recently
from
abf1fb0 to
c108752
Compare
Shaddoll
changed the title
yycptt
approved these changes
Apr 28, 2021
| @@ -4122,10 +4122,10 @@ func (s *ExecutionManagerSuite) TestConflictResolveWorkflowExecutionWithTransact | |||
| }, | |||
| Encoding: pickRandomEncoding(), | |||
| } | |||
| err = s.ExecutionManager.ConflictResolveWorkflowExecution(ctx, resetReq) | |||
| _, err = s.ExecutionManager.ConflictResolveWorkflowExecution(ctx, resetReq) | |||
There was a problem hiding this comment.
Shall we have some checks on the returned stats to make sure it's working?
Shaddoll
force-pushed
the
transaction-metrics
branch
from
c108752 to
00547e8
Compare
Shaddoll
force-pushed
the
transaction-metrics
branch
from
00547e8 to
bc59852
Compare
Shaddoll
added a commit
that referenced
this pull request
Apr 28, 2021
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Creating transfer/timer/replication tasks can issue large amount of write to databases.
We need to understand the load and set minimum requirements for databases.
How did you test it?
Potential risks
Release notes
Documentation Changes