Improve error handling for SQL persistence implementation #4178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Convert sqlplugin specific errors to common errors, such as timeout error, service busy error, entity not exists error.
Why?
Common errors are used to emit metrics in persistence layer. Different error types correspond to different metric names.
Our Cassandra implementation converts the errors to common error types as well. And we can use common errors to more intelligently decide if the call should be retried or not.
How did you test it?
Potential risks
Release notes
Documentation Changes