Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frontend client in parentClosePolicy workflow to allow auto-forwarding #4202

Merged
merged 3 commits into from
May 18, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented May 17, 2021

What changed?
Use frontend client in parentClosePolicy workflow

Why?
If workflow domain failovered to another cluster after parent close policy workflow receives the request, the request will keeping retrying as the domain is no-long active in the current cluster and there's no auto-forwarding for history client, which is currently used.

Switch to frontend client so that the request can be auto-forwarded to the new active cluster.

How did you test it?
Tested locally with samples

Potential risks
In the worst case, parent close policy workflow may stop working.

Release notes

Documentation Changes

@yycptt yycptt requested review from yux0 and longquanzheng May 17, 2021 23:52
@coveralls
Copy link

coveralls commented May 18, 2021

Pull Request Test Coverage Report for Build ee5626b1-e997-49fb-92f1-30ba704e50ac

  • 0 of 23 (0.0%) changed or added relevant lines in 3 files are covered.
  • 69 unchanged lines in 18 files lost coverage.
  • Overall coverage increased (+0.003%) to 59.934%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/worker/parentclosepolicy/processor.go 0 5 0.0%
service/worker/service.go 0 5 0.0%
service/worker/parentclosepolicy/workflow.go 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/task/task.go 1 82.52%
service/worker/parentclosepolicy/workflow.go 1 6.56%
client/history/client.go 2 44.78%
client/history/metricClient.go 2 49.43%
common/membership/rpServiceResolver.go 2 73.58%
common/persistence/executionStore.go 2 74.11%
common/persistence/statsComputer.go 2 96.36%
common/task/fifoTaskScheduler.go 2 82.47%
service/history/execution/mutable_state_builder.go 2 69.85%
service/history/handler.go 2 46.82%
Totals Coverage Status
Change from base Build db2a5907-d7b0-456d-9f33-e83b34b4b215: 0.003%
Covered Lines: 88200
Relevant Lines: 147163

💛 - Coveralls

@yycptt yycptt merged commit d1c7116 into cadence-workflow:master May 18, 2021
@yycptt yycptt deleted the fix-parentclosepolicy-wf branch May 18, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants