Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick signal requestID dedup fix from temporal #4210

Merged
merged 3 commits into from
May 24, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented May 21, 2021

What changed?

  • Check if signal is duplicated before if workflow is closed
  • Do not update workflow for duplicated signal

Why?
Pick temporalio/temporal#1558

How did you test it?

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested review from yux0 and a team May 21, 2021 18:48
@coveralls
Copy link

coveralls commented May 21, 2021

Pull Request Test Coverage Report for Build e4f65a7c-c6e5-48c4-9ea5-fccf51c7fb94

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • 73 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.004%) to 60.0%

Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
service/history/queue/timer_queue_processor.go 2 58.77%
service/matching/taskListManager.go 2 74.72%
common/persistence/cassandra/cassandraPersistence.go 6 52.56%
common/persistence/cassandra/cassandraPersistenceUtil.go 62 89.12%
Totals Coverage Status
Change from base Build a9339770-f738-4d36-9510-4a1494da3612: -0.004%
Covered Lines: 88551
Relevant Lines: 147584

💛 - Coveralls

@yycptt yycptt merged commit 2fb5c02 into cadence-workflow:master May 24, 2021
@yycptt yycptt deleted the pick-temporal branch May 24, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants