Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain queue ack level fix #4218

Merged
merged 4 commits into from
May 25, 2021
Merged

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented May 25, 2021

What changed?

  1. Domain DLQ ack level fix
  2. temporalio/temporal@1867fa7

Why?
Domain replication queue related bugs

How did you test it?
Local tests

Potential risks

Release notes

Documentation Changes

@yux0 yux0 requested review from yycptt and a team May 25, 2021 17:05
@coveralls
Copy link

coveralls commented May 25, 2021

Pull Request Test Coverage Report for Build e83176a6-db81-4f17-b5b4-bbb8c735779d

  • 0 of 5 (0.0%) changed or added relevant lines in 2 files are covered.
  • 80 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.02%) to 59.988%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/sql/sqlQueue.go 0 1 0.0%
common/domain/replication_queue.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
common/domain/replication_queue.go 1 10.24%
service/history/execution/mutable_state_task_refresher.go 1 75.23%
client/history/client.go 2 44.78%
client/history/metricClient.go 2 49.43%
common/persistence/executionStore.go 2 74.11%
common/persistence/statsComputer.go 2 96.36%
common/task/fifoTaskScheduler.go 2 85.57%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/execution/mutable_state_builder.go 2 69.82%
service/history/handler.go 2 46.67%
Totals Coverage Status
Change from base Build 5e943b81-dad7-484d-a958-1689e4676eb7: 0.02%
Covered Lines: 88511
Relevant Lines: 147549

💛 - Coveralls

@yux0 yux0 merged commit e2cde4a into cadence-workflow:master May 25, 2021
@yux0 yux0 deleted the domain_queue_fix branch May 25, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants