Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross-cluster task related types and methods to data/persistence interface #4225

Merged
merged 3 commits into from
May 26, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented May 26, 2021

What changed?
Add cross-cluster task related types and methods to data/persistence interface

Why?
For supporting cross-domain/cluster operation

How did you test it?

  • Existing persistence test
  • Since this pr only add methods and fields to existing struct & interface def, the fact that the code compiles also shows the correctness to some degree

Potential risks
N/A, the newly added fields is not used or persisted.

Release notes

Documentation Changes

@yycptt yycptt requested review from yux0 and a team May 26, 2021 17:39
@coveralls
Copy link

coveralls commented May 26, 2021

Pull Request Test Coverage Report for Build e28c2022-ee3a-4abd-92fd-6d6a539a83be

  • 22 of 191 (11.52%) changed or added relevant lines in 10 files are covered.
  • 96 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.1%) to 59.884%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/cassandra/cassandraPersistence.go 0 9 0.0%
common/persistence/executionStore.go 8 17 47.06%
common/persistence/sql/sqlExecutionManager.go 0 9 0.0%
common/persistence/persistenceRateLimitedClients.go 0 18 0.0%
common/persistence/persistenceMetricClients.go 0 33 0.0%
common/persistence/dataInterfaces.go 0 36 0.0%
common/persistence/persistenceErrorInjectionClients.go 0 55 0.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/sql/sqlExecutionManager.go 1 59.76%
client/history/client.go 2 44.78%
client/history/metricClient.go 2 49.43%
common/membership/rpServiceResolver.go 2 73.58%
common/persistence/executionStore.go 2 73.36%
common/persistence/statsComputer.go 2 96.43%
common/task/fifoTaskScheduler.go 2 84.54%
service/history/handler.go 2 46.67%
service/matching/taskListManager.go 2 74.72%
service/frontend/workflowHandler.go 4 58.35%
Totals Coverage Status
Change from base Build 5a28480a-ae04-4683-8b84-e7c230e07e40: -0.1%
Covered Lines: 88503
Relevant Lines: 147790

💛 - Coveralls

@yycptt yycptt merged commit bda4c5c into cadence-workflow:master May 26, 2021
@yycptt yycptt deleted the cross-cluster-queue-interface branch May 26, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants